Max Speed on UPnP Ports should be in Kbytes

Discuss the technical details of Gargoyle and ongoing development

Moderator: Moderators

Post Reply
Libra
Posts: 9
Joined: Wed Mar 07, 2012 6:28 pm
Location: Belgium

Max Speed on UPnP Ports should be in Kbytes

Post by Libra »

The Max Speed on UPnP Ports (/port_forwarding.sh) should be entered in Kbytes instead of Kbit because miniupnp does * 8.

Code: Select all

diff --git a/package/gargoyle/files/www/port_forwarding.sh b/package/gargoyle/files/www/port_forwarding.sh
index 46b297a..c83d4db 100755
--- a/package/gargoyle/files/www/port_forwarding.sh
+++ b/package/gargoyle/files/www/port_forwarding.sh
@@ -89,7 +89,7 @@
 			<label class='leftcolumn' for='upnp_up' id='upnp_up_label'>Max Up Speed on UPnP Ports:</label>
 			<span class = 'rightcolumn'>
 				<input type='text' class='rightcolumn' id='upnp_up' onkeyup='proofreadNumeric(this)' size='5' maxlength='5' />
-				<em>Kbit / second</em>
+				<em>Kbytes / second</em>
 			</span>
 		</div>
 
@@ -97,7 +97,7 @@
 			<label class='leftcolumn' for='upnp_down' id='upnp_down_label'>Max Down Speed on UPnP Ports:</label>
 			<span class='rightcolumn'>
 				<input type='text' id='upnp_down' onkeyup='proofreadNumeric(this)' size='5' maxlength='5' />
-				<em>Kbit / second</em>
+				<em>Kbytes / second</em>
 			</span>
 		</div>
 		

pbix
Developer
Posts: 1373
Joined: Fri Aug 21, 2009 5:09 pm

Re: Max Speed on UPnP Ports should be in Kbytes

Post by pbix »

I committed this fix today, thanks for the report.
Linksys WRT1900ACv2
Netgear WNDR3700v2
TP Link 1043ND v3
TP-Link TL-WDR3600 v1
Buffalo WZR-HP-G300NH2
WRT54G-TM

Post Reply