SMB share shown as empty with version 1.15.x_20241113

[toktok]

Hi,

I can't get USB storage sharing via CIFS to work with firmware version 1.15.x_20241113. It did work previously with the stable 1.14.0 firmware.
The problem is that the USB Storage is shown as empty on the remote device. (tried Windows and Linux)

Via FTP the files on the USB storage are shown and everything appears to be working as it should.

Here is a list of other tests I did:

- Use an EXT4 formated USB disk -> same result as with FAT32 and NTFS (i.e. no files shown).

- Copy files from a client computer over the network to the Gargoyle SMB share (i.e. write file) -> the file copy succeeds, but the copied files are then not shown on the client computer. Unmounted the USB disk from the router and plugged it into a computer -> the newly written files are there.

- Created a new folder /tmp/test on the Gargoyle router, modified /etc/config/ksmbd to point to /tmp/test ("option path '/tmp/test'") and restarted the ksmbd service -> everything works perfectly fine.

This kind of sounds like an issue with read permissions, but it is not something obvious, as I haven't been able to spot anything that doesn't look right.

Has anyone successfully tested USB storage sharing via CIFS with 1.15.x?

[Lantis]

https://github.com/ericpaulbishop/gargo ... 886099170d

I will post a new build with the fix.

[Lantis]

https://lantisproject.com/downloads/gar ... DMzMSJdXX0

Images will be available in the next 2 hours

[toktok]

Thank you very much! I truly appreciate your efforts. This build fixes the above mentioned problem.

By the way, there is another issue with ksmbd. Perhaps I should have mentioned this earlier already, but I had not investigated it myself yet, so I wasn't sure if it was just me doing something wrong.

Apparently, Gargoyle always mounts USB disks by their UUID and if the user wishes to be able to swap USB disks freely without having to "Add" every single one of them first, then the option "Settings Apply To:" can be set to "The same Partition On Any USB Drive". This changes the "path" in /etc/config/ksmbd from the actual mount point to "/tmp/usb_mount/dev_sda1", which is a constant symbolic link to the actual mount point of the USB drive.

I could be wrong, but I seem to remember that OpenWrt does it the other way around, i.e. mount the USB drive either by UUID (=specific drive) or by device name like /dev/sda1 (=any drive), but the path for the drive remains unchanged.

Anyway, when I set "Settings Apply To:" to "The same Partition On Any USB Drive", then things work fine via FTP, but not via CIFS. (again )
I don't know why. Could it be that ksmbd somehow refuses to work with a symbolic link for whatever reason?

I think this actually was also the case with 1.14.0 stable, but as I indicated above I didn’t bother, because the setting “Only This Specific Drive” has been good enough for me.

[Lantis]

I will look into this, but on a quick search it looks like ksmbd doesn’t support symlinks.
The switch to ksmbd has been a little hairy. It does make me consider reinstating samba36 but I feel that ksmbd is the future.