1.11.0.x gargoyle-ispy 2019-June-23 04

[Lantis]

Hi about the new modals. They don't show up to a screen reader. I know of a way to get my screen reader to see the window, but most screen reader users would not even know that a modal event had been initiated.
https://www.w3.org/TR/wai-aria-practice ... ialog.html
https://developer.yoast.com/the-a11y-mo ... ccessible/

edit:ispy

I've made the modals more a11y friendly with this commit.

1. When modal opens, focus is forced to the modal itself
2. When the modal closes, focus is returned to the calling element (usually the 'Add' or 'Edit' button).
3. Modals now have aria-labelledby tags to announce them on open, and aria-hidden tags to hide them from the screen reader when not active
4. Presses of the TAB key are intercepted and forced to only cycle through items within the active modal
5. Presses of the ESC key are intercepted and now close the modal

Hope that helps.

[ispyisail]

building

[tapper]

Hi about the new modals. They don't show up to a screen reader. I know of a way to get my screen reader to see the window, but most screen reader users would not even know that a modal event had been initiated.
https://www.w3.org/TR/wai-aria-practice ... ialog.html
https://developer.yoast.com/the-a11y-mo ... ccessible/

edit:ispy

I've made the modals more a11y friendly with this commit.

1. When modal opens, focus is forced to the modal itself
2. When the modal closes, focus is returned to the calling element (usually the 'Add' or 'Edit' button).
3. Modals now have aria-labelledby tags to announce them on open, and aria-hidden tags to hide them from the screen reader when not active
4. Presses of the TAB key are intercepted and forced to only cycle through items within the active modal
5. Presses of the ESC key are intercepted and now close the modal

Hope that helps.

Thanks sounds good. I will test and let you know. Thanks for the fast fix to!

[CBx86]

Nice work, guys.