1.11.0.x gargoyle-ispy 2019-June-23 04

Want to share your OpenWrt / Gargoyle knowledge? Implemented a new feature? Let us know here.

Moderator: Moderators

Lantis
Moderator
Posts: 5773
Joined: Mon Jan 05, 2015 5:33 am
Location: Australia

Re: 1.11.0.x gargoyle-ispy 2019-June-23 04

Post by Lantis »

tapper wrote:Hi about the new modals. They don't show up to a screen reader. I know of a way to get my screen reader to see the window, but most screen reader users would not even know that a modal event had been initiated.
https://www.w3.org/TR/wai-aria-practice ... ialog.html
https://developer.yoast.com/the-a11y-mo ... ccessible/

edit:ispy


I've made the modals more a11y friendly with this commit.
  1. When modal opens, focus is forced to the modal itself
  2. When the modal closes, focus is returned to the calling element (usually the 'Add' or 'Edit' button).
  3. Modals now have aria-labelledby tags to announce them on open, and aria-hidden tags to hide them from the screen reader when not active
  4. Presses of the TAB key are intercepted and forced to only cycle through items within the active modal
  5. Presses of the ESC key are intercepted and now close the modal

Hope that helps.
http://lantisproject.com/downloads/gargoyle_ispyisail.php for the latest releases
Please be respectful when posting. I do this in my free time on a volunteer basis.

ispyisail
Moderator
Posts: 4884
Joined: Mon Apr 06, 2009 3:15 am
Location: New Zealand

Re: 1.11.0.x gargoyle-ispy 2019-June-23 04

Post by ispyisail »

building

tapper
Moderator
Posts: 1071
Joined: Sun Oct 13, 2013 5:49 pm
Location: Stoke-on-trent UK

Re: 1.11.0.x gargoyle-ispy 2019-June-23 04

Post by tapper »

Lantis wrote:
tapper wrote:Hi about the new modals. They don't show up to a screen reader. I know of a way to get my screen reader to see the window, but most screen reader users would not even know that a modal event had been initiated.
https://www.w3.org/TR/wai-aria-practice ... ialog.html
https://developer.yoast.com/the-a11y-mo ... ccessible/

edit:ispy


I've made the modals more a11y friendly with this commit.
  1. When modal opens, focus is forced to the modal itself
  2. When the modal closes, focus is returned to the calling element (usually the 'Add' or 'Edit' button).
  3. Modals now have aria-labelledby tags to announce them on open, and aria-hidden tags to hide them from the screen reader when not active
  4. Presses of the TAB key are intercepted and forced to only cycle through items within the active modal
  5. Presses of the ESC key are intercepted and now close the modal

Hope that helps.

Thanks sounds good. I will test and let you know. Thanks for the fast fix to!
Linksys WRT1900AC V2 Gargoyle 1.11
Linksys WRT3200ACM OpenWrt Snapshot

User avatar
CBx86
Posts: 146
Joined: Sun Jan 05, 2014 5:43 pm
Location: Brazil

Re: 1.11.0.x gargoyle-ispy 2019-June-23 04

Post by CBx86 »

Nice work, guys. :D

Post Reply