Min RTT bug with Chinese interface. (1.9)

[Gzxhwq]

Hello,

I'm sorry for my english.

Qos "Min RTT" setting can not save, when use the Chinese interface.

I think it might be a bug.

Version: 1.9.0
Hardware: NETGEAR WNDR4300

[ispyisail]

screen shot please

[gatalon]

screen shot please

Hey, I can confirm this bug exist. when i chose chinese language, the minrtt setting on qos download page can not save.
My router is wndrmac use 1.9.0 version firmware.

[Lantis]

Can you please detail the error either with screenshots of a web browser console (e.g. Chrome via F12) or via a logread run on the router.

Otherwise it's very hard to track down the issue and fix it for you.

[gatalon]

Can you please detail the error either with screenshots of a web browser console (e.g. Chrome via F12) or via a logread run on the router.

Otherwise it's very hard to track down the issue and fix it for you.

when I want to upload some screenshots, I got this:
Sorry, the board attachment quota has been reached.
maybe because I am a newcomer.
I give you the detail step to playback the bug.
Follow the step below with any browser.
Step 1:
set the language to " 中文（简体）ZH-CN language strings for Gargoyle web interface "
Step 2:
located to Firewall>QOS(Download)
Section: QoS (Download) -- Service Classes
edit fast service class select
"Minimize RTT (ping times) when active"
Step 3:
click "close and apply changes" button
Step 4:
click "save changes" button at the bottom
with ZH-CN interface you will find the edited fast service class's MinRTT not show yes, just like edited before.
Step 5:
change the language to default you will find the fast service class's MinRTT show yes now.

so, it is a chinese language display issue?

[Lantis]

Alright, i've confirmed the bug. I'll see if i can figure out why it is happening. Very strange!

[Lantis]

Fixed!

Thanks for your detailed description of the problem.
This fix will hopefully be available in a few days time from ispyisail in the Show and Tell Forum.

If you want to fix it yourself for now, please change line 302 of
/www/js/qos.js
from

Code: Select all

classRow.MinRTT = classRow.MinRTT == qosStr.YES ? classRow.MinRTT : "";

to

Code: Select all

classRow.MinRTT = classRow.MinRTT == "Yes" ? qosStr.YES : "";

[gatalon]

Fixed!

Thanks for your detailed description of the problem.
This fix will hopefully be available in a few days time from ispyisail in the Show and Tell Forum.

If you want to fix it yourself for now, please change line 302 of
/www/js/qos.js
from

Code: Select all

classRow.MinRTT = classRow.MinRTT == qosStr.YES ? classRow.MinRTT : "";

to

Code: Select all

classRow.MinRTT = classRow.MinRTT == "Yes" ? qosStr.YES : "";

Thank you very much for your professional reply.