e7e865b1 corrupts downloads from router with prepended crlf
Posted: Sun Dec 01, 2013 3:13 pm
Hi,
as this is my first post here, let me thank all contributors of gargoyle for their efforts. Keep on!
I recently upgraded from 1.5.10 to 1.5.11, and after some messing with manual 3g-failover, i needed to reset and restore. While restoring a backup from 10 worked, a fresh backup from 11 failed. I noticed that the backup file form 11 did not open with tar because of invalid magics. Indeed it had crlf at the beginning, followed by gzip magics. Wireshark showed that this crlf was sent in its own packet. openVPN credential download showed the same behaviour, but zip seems to be more tolerant.
Originally i wanted to ask for help at this point, but i took too long to write, and the php session-management ate my post. So i decided to have a look at the code, and presumably found the cause in httpd_gargoyle.c:2590 , which came from change e7e865b1.
I don't know the original reason for this change and am about to try a fixed build, so can someone have a look at this?
Thanks!
Regards
RJ
as this is my first post here, let me thank all contributors of gargoyle for their efforts. Keep on!
I recently upgraded from 1.5.10 to 1.5.11, and after some messing with manual 3g-failover, i needed to reset and restore. While restoring a backup from 10 worked, a fresh backup from 11 failed. I noticed that the backup file form 11 did not open with tar because of invalid magics. Indeed it had crlf at the beginning, followed by gzip magics. Wireshark showed that this crlf was sent in its own packet. openVPN credential download showed the same behaviour, but zip seems to be more tolerant.
Originally i wanted to ask for help at this point, but i took too long to write, and the php session-management ate my post. So i decided to have a look at the code, and presumably found the cause in httpd_gargoyle.c:2590 , which came from change e7e865b1.
I don't know the original reason for this change and am about to try a fixed build, so can someone have a look at this?
Thanks!
Regards
RJ