Gargoyle Forum

Hi,

running 1.12 (my router fails at anything above that).

Two very annoying issues:

1. Sometimes I need to disable the Wireless MAC Filter as it's the only way to find out the MAC address of a device. The device can then connect, I can see its MAC address and then re-enable the filtering. The problem is that when I re-enable the MAC Filter all the previous entries are GONE. So disabling not only sets a boolean to false, no, it also clears the list. WHY!? Now I have to remind myself every time to first make a backup, then disable the MAC Filter, and then restore the backup.

2. I want the DHCP server to be OFF (I've got something else that does my DHCP) but every time I restore a backup the DHCP server is switched to ON again. This has lead to countless wasted hours trying to find out what was wrong with my network only to discover that because there were now suddenly two DHCP servers active things were a mess. WHY is DHCP turned on after a restore?

Anyone?

1. This is known behaviour. I will consider a fix in the future but it is low priority. It will not be backported.
2. As far as I am aware, restoring the configuration does not explicitly set or unset dhcp server. It will be restored to whatever state it was in the backup.
If you are absolutely certain this is happening then I can investigate.
What is much more likely is you are experiencing that DHCP turns back on ANY TIME you press Save Changes on the Connection Basic page.
This bug was fixed in later versions and will not be backported.

Please be aware that 1.12 is 4 years old and significantly out of date, has many unresolved security issues, and is out of support.
If you can’t or won’t update, the level of support you can expect is rapidly reducing.

1. As a software engineer myself I can't imagine the fix being anything more than commenting out the line where the list is cleared when filtering is disabled. Maybe low priority but very easy fix.
2. You are right, it turns out to be the saving of changes that turns on DHCP. But not 'ANY TIME' because the only 'Save Changes' that doesn't show this behaviour is the one on the DHCP page itself (or we'd never be able to turn DHCP off). But as you say it's been fixed in since 1.12

I would love to install 1.14 but I have tried that in the past and it failed miserably though I don't remember the details. I just remember that I realised I had to stay on 1.12 for some reason.

FYI I am running an Archer C7 v2 and a 1043 v4, both supported. Anything you can think of that would prevent them from working properly?

Well then as a software engineer, jump into the code and fix it then..?
All Pull Requests are welcome.
As a software engineer you know that it doesn’t take one line to change it.
It takes:
- understanding of OpenWrt
- understanding of the uci system
- understanding of the wifi configuration items and how they interact
- understanding of the Gargoyle GUI
- understanding of the Gargoyle backend
- understanding of several coding languages
- time

I am rich in all of those things, except for time.
The required change is to remove the macfilter line from the config. Maclist can probably stay. Then the Gargoyle side must be recoded to understand that presence of the maclist alone does not trigger the UI to show enabled. If the user toggles enabled then bring the (potentially already populated) list in.

The reason it is low priority is that it is a very trivial form of wifi security which is open to bypass. Therefore a Mac restriction in the firewall (which can be toggled on and off without losing the list) is a bit more robust and probably a reasonable substitute, barring any specifics of your intended use case.
It is also low priority because I’m rewriting that entire interface page, and it would be easier to include it there.


To the second point, I said any time it is saved on Connection Basic. Of course DHCP works.
Here’s the two commits if you want to backport it for yourself.
https://github.com/ericpaulbishop/gargo ... 44ec83508a
https://github.com/ericpaulbishop/gargo ... 352339f0b3

I don’t want my reply to sound snarky but let’s not trivialise my efforts when I’m the only one doing anything long term with this project and the founder has gone complete radio silence.

I would jump into the code and fix it if I
- understood OpenWrt
- understood the uci system
...
- had time



Look, I absolutely appreciate your efforts and the work you do, AND being an active replier here on the forum. So, many thanks for that, apologies if I sound snarky.

I won't be backporting because I did the update to 1.14 again (see other topic as it wasn't flawless) but thanks for the links.