Page 1 of 1

ddns_gargoyle leaves sockets in CLOSE_WAIT status

Posted: Sun Aug 21, 2011 8:43 am
by mackoj
Hello,
I'm using Gargoyle 1.3.16

I've notice a problem, that ddns_gargoyle is leaving CLOSE_WAIT connections.
As I can see the libewget.c (used by ddns_gargoyle) has a bug in destroy_connection_http function.

Shouldn't be there close(socket) before free(socket)?

Best Regards,
MJ

Re: ddns_gargoyle leaves sockets in CLOSE_WAIT status

Posted: Mon Aug 22, 2011 4:08 pm
by sco77
What all does this bug affect?

Re: ddns_gargoyle leaves sockets in CLOSE_WAIT status

Posted: Mon Aug 22, 2011 5:30 pm
by mackoj
ddns-gargoyle leaves open sockets, so you have to restart it to free resources.

Re: ddns_gargoyle leaves sockets in CLOSE_WAIT status

Posted: Mon Aug 22, 2011 6:20 pm
by sco77
So it's only a problem with dynamic DNS? Just wanted to know since I noticed it's been fixed in repository and wanted to know if it was worth compiling.

Re: ddns_gargoyle leaves sockets in CLOSE_WAIT status

Posted: Tue Aug 23, 2011 2:41 am
by mackoj
I noticed the problem with dynDNS only.
However root of the bug is in ewget lib, and I'm not sure if this is even noticeable in ewget.

Re: ddns_gargoyle leaves sockets in CLOSE_WAIT status

Posted: Tue Aug 23, 2011 7:25 am
by pbix
It seems Eric has fixed this issue in the repo so it should be correct in the next release of Gargoyle. You can see yourself at http://www.gargoyle-router.com/gargoyle rev:6c66f0cf

Thanks for your investigation and report.