AdBlock bugulance
Posted: Sun Dec 08, 2019 1:28 am
Gargoyle developers and maintainers,
I have not logged in for a number of days and thus only became aware of the release of 1.12 in the last few minutes. As such, I have not installed it upon my router, nor am aware of if this issue is resolved with that version or not.
There exists within the scope of the Gargoyle AdBlock plugin code some bugulance in need of remediation.
crontab (as configured by AdBlock upon initial setup) ostensibly executes a script to update the AdBlock files at 4AM, on any Sunday of any week of any month. However, I noticed my AdBlock updates were not automatically forthcoming and thus I conducted an investigation as to what the instigates were to such anomalous behavior.
Notwithstanding the choice of executing the script via cron or from the command line, the results nonetheless should be coterminous. Thus, I exacted a test from the command line in order observe any results.
Within the /etc/crontab/root file there exists a line:
0 4 * * 0 sh /plugin_root/usr/lib/adblock/runadblock.sh
However, when tested from the command line a problem become rather obvious:
root@wrt3200acm:/# sh /plugin_root/usr/lib/adblock/runadblock.sh
uci: Parse error (option/list command found before the first section) at line 1, byte 1
root@wrt3200acm:/#
The offending line would seem to be line 138 (as follows hereupon):
uci set adblock.config.lastrun="$LASTRUN" && uci commit
I am not familiar with the uci command, its source or what it does (except to say I did read the help provided by the command line help option).
I will try to do some further experimentation as time permits; however, I am sure there are folks here far more familiar with the uci program than I and likely will conclude the solution faster than I will.
Thank you in advance and as always to everyone that takes time to maintain and improve this project.
I am off to backup my router and obtain the lastest 1.12 version of the firmware.
I have not logged in for a number of days and thus only became aware of the release of 1.12 in the last few minutes. As such, I have not installed it upon my router, nor am aware of if this issue is resolved with that version or not.
There exists within the scope of the Gargoyle AdBlock plugin code some bugulance in need of remediation.
crontab (as configured by AdBlock upon initial setup) ostensibly executes a script to update the AdBlock files at 4AM, on any Sunday of any week of any month. However, I noticed my AdBlock updates were not automatically forthcoming and thus I conducted an investigation as to what the instigates were to such anomalous behavior.
Notwithstanding the choice of executing the script via cron or from the command line, the results nonetheless should be coterminous. Thus, I exacted a test from the command line in order observe any results.
Within the /etc/crontab/root file there exists a line:
0 4 * * 0 sh /plugin_root/usr/lib/adblock/runadblock.sh
However, when tested from the command line a problem become rather obvious:
root@wrt3200acm:/# sh /plugin_root/usr/lib/adblock/runadblock.sh
uci: Parse error (option/list command found before the first section) at line 1, byte 1
root@wrt3200acm:/#
The offending line would seem to be line 138 (as follows hereupon):
uci set adblock.config.lastrun="$LASTRUN" && uci commit
I am not familiar with the uci command, its source or what it does (except to say I did read the help provided by the command line help option).
I will try to do some further experimentation as time permits; however, I am sure there are folks here far more familiar with the uci program than I and likely will conclude the solution faster than I will.
Thank you in advance and as always to everyone that takes time to maintain and improve this project.
I am off to backup my router and obtain the lastest 1.12 version of the firmware.