LAN Port Indicator, is it removed or moved somewhere else?

General discussion about Gargoyle, OpenWrt or anything else even remotely related to the project

Moderator: Moderators

Post Reply
Blebekblebek
Posts: 17
Joined: Fri May 11, 2018 10:24 pm

LAN Port Indicator, is it removed or moved somewhere else?

Post by Blebekblebek »

I've been using 1.12 version for some quite time, and my only grip with it is the lack of lan port indicator unlike the older version.
Old version:
https://www.gargoyle-router.com/wiki/li ... erview.jpg

New version:
https://i.imgur.com/dK5aNm6.png

I rarely look at it before this, however one day my internet speed became slower and capped at 10mbps, rebooting modem/router doesn't solve the issue until I plug the older router back and see lan port indicator only works at 10mbps (supposed to be 100mbps), re-crimping rj45 and re-plugging seems fix it, but after this incident I think this feature really important and very convenient, so why does it being removed?

Lantis
Moderator
Posts: 6735
Joined: Mon Jan 05, 2015 5:33 am
Location: Australia

Re: LAN Port Indicator, is it removed or moved somewhere else?

Post by Lantis »

It was removed unintentionally as part of another bug fix, and was re-added later.
You can modify it on your own router if you like, or run a later version.
https://github.com/ericpaulbishop/gargo ... c57956e3e5
http://lantisproject.com/downloads/gargoyle_ispyisail.php for the latest releases
Please be respectful when posting. I do this in my free time on a volunteer basis.

Blebekblebek
Posts: 17
Joined: Fri May 11, 2018 10:24 pm

Re: LAN Port Indicator, is it removed or moved somewhere else?

Post by Blebekblebek »

okay, unfortunately my units isn't officially supported, I'm currently using CPE210 & MT300NV2 which both provided by https://dl.eko.one.pl/gargoyle-pl/openw ... ps/mt76x8/

Is there any plan to support these devices officially?
I'll try fix immediately, thank you very much.

Lantis
Moderator
Posts: 6735
Joined: Mon Jan 05, 2015 5:33 am
Location: Australia

Re: LAN Port Indicator, is it removed or moved somewhere else?

Post by Lantis »

Ask Obsy :) If they work well and he wants to push the support for them upstream, no worries!

I'm pretty open to the mt76x8 arch because i have a device sitting here which uses it.
http://lantisproject.com/downloads/gargoyle_ispyisail.php for the latest releases
Please be respectful when posting. I do this in my free time on a volunteer basis.

Blebekblebek
Posts: 17
Joined: Fri May 11, 2018 10:24 pm

Re: LAN Port Indicator, is it removed or moved somewhere else?

Post by Blebekblebek »

I've changed it, and copied the whole text, but it doesn't seems working, maybe because it's 2 lan port units?
Even with 1.10 it doesn't show up either, it's because the PL version?

Lantis
Moderator
Posts: 6735
Joined: Mon Jan 05, 2015 5:33 am
Location: Australia

Re: LAN Port Indicator, is it removed or moved somewhere else?

Post by Lantis »

Post the contents of your /etc/board.json here please.
http://lantisproject.com/downloads/gargoyle_ispyisail.php for the latest releases
Please be respectful when posting. I do this in my free time on a volunteer basis.

Blebekblebek
Posts: 17
Joined: Fri May 11, 2018 10:24 pm

Re: LAN Port Indicator, is it removed or moved somewhere else?

Post by Blebekblebek »

CPE210v1
{
"model": {
"id": "cpe210",
"name": "TP-Link CPE210 v1.1"
},
"rssimon": {
"wlan0": {
"refresh": 200000,
"threshold": 1
}
},
"led": {
"rssilow": {
"name": "",
"sysfs": "tp-link:green:link1",
"type": "rssi",
"iface": "wlan0",
"minq": "1",
"maxq": "100",
"offset": "0",
"factor": "13"
},
"rssimediumlow": {
"name": "",
"sysfs": "tp-link:green:link2",
"type": "rssi",
"iface": "wlan0",
"minq": "26",
"maxq": "100",
"offset": "-25",
"factor": "13"
},
"rssimediumhigh": {
"name": "",
"sysfs": "tp-link:green:link3",
"type": "rssi",
"iface": "wlan0",
"minq": "51",
"maxq": "100",
"offset": "-50",
"factor": "13"
},
"rssihigh": {
"name": "",
"sysfs": "tp-link:green:link4",
"type": "rssi",
"iface": "wlan0",
"minq": "76",
"maxq": "100",
"offset": "-75",
"factor": "13"
},
"lan0": {
"name": "LAN0",
"sysfs": "tp-link:green:lan0",
"trigger": "switch0",
"type": "switch",
"port_mask": "0x20",
"speed_mask": ""
},
"lan1": {
"name": "LAN1",
"sysfs": "tp-link:green:lan1",
"trigger": "switch0",
"type": "switch",
"port_mask": "0x10",
"speed_mask": ""
}
},
"switch": {
"switch0": {
"enable": true,
"reset": true,
"ports": [
{
"num": 0,
"device": "eth0",
"need_tag": false,
"want_untag": false
},
{
"num": 5,
"role": "lan"
},
{
"num": 4,
"role": "wan"
}
],
"roles": [
{
"role": "lan",
"ports": "5 0t",
"device": "eth0.1"
},
{
"role": "wan",
"ports": "4 0t",
"device": "eth0.2"
}
]
}
},
"network": {
"lan": {
"ifname": "eth0.1",
"protocol": "static"
},
"wan": {
"ifname": "eth0.2",
"protocol": "dhcp"
}
},
"gpioswitch": {
"poe_passthrough": {
"name": "PoE Passthrough",
"pin": 20,
"default": 0
}
}
}
Last edited by Blebekblebek on Tue Jan 26, 2021 1:59 am, edited 1 time in total.

Blebekblebek
Posts: 17
Joined: Fri May 11, 2018 10:24 pm

Re: LAN Port Indicator, is it removed or moved somewhere else?

Post by Blebekblebek »

MT300nv2
{
"model": {
"id": "gl-mt300n-v2",
"name": "GL-MT300N-V2"
},
"led": {
"wifi_led": {
"name": "wifi",
"sysfs": "gl-mt300n-v2:red:wlan",
"type": "netdev",
"device": "wlan0",
"mode": "link tx rx"
},
"wan": {
"name": "wan",
"sysfs": "gl-mt300n-v2:green:wan",
"trigger": "switch0",
"type": "switch",
"port_mask": "0x1",
"speed_mask": ""
}
},
"switch": {
"switch0": {
"enable": true,
"reset": true,
"ports": [
{
"num": 1,
"role": "lan"
},
{
"num": 0,
"role": "wan"
},
{
"num": 6,
"device": "eth0",
"need_tag": false,
"want_untag": false
}
],
"roles": [
{
"role": "lan",
"ports": "1 6t",
"device": "eth0.1"
},
{
"role": "wan",
"ports": "0 6t",
"device": "eth0.2"
}
]
}
},
"network": {
"lan": {
"ifname": "eth0.1",
"protocol": "static"
},
"wan": {
"ifname": "eth0.2",
"protocol": "dhcp",
"macaddr": "94:83:c4:04:3d:ad"
}
}
}

Lantis
Moderator
Posts: 6735
Joined: Mon Jan 05, 2015 5:33 am
Location: Australia

Re: LAN Port Indicator, is it removed or moved somewhere else?

Post by Lantis »

The logic was changed to use code that is device generic and should work for more devices.
Your devices board.json file doesn't get populated with enough information for us to figure out the port status. It is missing the "index" number.

Here's an extract from my own device:

Code: Select all

	"switch": {
		"switch0": {
			"enable": true,
			"reset": true,
			"ports": [
				{
					"num": 1,
					"role": "lan",
					"index": 4
				},
				{
					"num": 2,
					"role": "lan",
					"index": 3
				},
				{
					"num": 3,
					"role": "lan",
					"index": 2
				},
				{
					"num": 4,
					"role": "lan",
					"index": 1
				},
				{
					"num": 6,
					"device": "eth1",
					"need_tag": false,
					"want_untag": false
				},
				{
					"num": 5,
					"role": "wan"
				},
				{
					"num": 0,
					"device": "eth0",
					"need_tag": false,
					"want_untag": false
				}
			],
			"roles": [
				{
					"role": "lan",
					"ports": "1 2 3 4 6t",
					"device": "eth1.1"
				},
				{
					"role": "wan",
					"ports": "5 0t",
					"device": "eth0.2"
				}
			]
		}
	},
We can make the following changes to the code to make it work, I'm just not sure if it is wise yet. I need to look further into what other trouble it might cause.
/usr/lib/gargoyle/switchinfo.sh

Code: Select all

 	json_select $PORT
 	json_get_var PHYSICAL index
 	json_get_var LOGICAL num
+	json_get_var ROLE role
	json_select ..
-	if [ -n "$PHYSICAL" ] && [ -n "$LOGICAL" ] ; then
+	if [ "$ROLE" = "lan" ] && [ -n "$LOGICAL" ] ; then
 		[ "$P" = "-1" ] && continue
 		[ -n "$VLAN" ] && {
 			PVID=$(swconfig dev $SWITCHID port $LOGICAL get pvid)
Feel free to try it on your own device for now while i think further.
http://lantisproject.com/downloads/gargoyle_ispyisail.php for the latest releases
Please be respectful when posting. I do this in my free time on a volunteer basis.

Post Reply