Slight improvement for 1.9.2 on mobile screens

Suggest improvements and new features for Gargoyle.

Moderator: Moderators

Post Reply
dsalch
Posts: 123
Joined: Wed Jan 06, 2016 2:09 pm
Location: Tx

Slight improvement for 1.9.2 on mobile screens

Post by dsalch »

Love the new interface! Thanks Thanks! much better for smaller screens!

One thing that is a bit awkward for small screens like smartphones, is the need to double click now to get to submenues under a different main menu item.

for instance, to get to "Firewall -> QOS DOWNLOAD" from the "STATUS-> QOS Distribution" screen, required the following:

click the hamburger
choose firewall
click the hamburger
choose the QOS download option

Could there be a way to reduce the number of clicks required?

Not a big deal, just a tad irritating when going back and forth between submenus.

Lantis
Moderator
Posts: 6735
Joined: Mon Jan 05, 2015 5:33 am
Location: Australia

Re: Slight improvement for 1.9.2 on mobile screens

Post by Lantis »

Currently looking into this.
Just trying to make sure it's done in a sensible way that is still configurable by themes
http://lantisproject.com/downloads/gargoyle_ispyisail.php for the latest releases
Please be respectful when posting. I do this in my free time on a volunteer basis.

Lantis
Moderator
Posts: 6735
Joined: Mon Jan 05, 2015 5:33 am
Location: Australia

Re: Slight improvement for 1.9.2 on mobile screens

Post by Lantis »

Have written a cool bit of concept code which allows this to happen smoothly.
Watch it here

Theme developers can even choose to enable it or disable it for their theme!
http://lantisproject.com/downloads/gargoyle_ispyisail.php for the latest releases
Please be respectful when posting. I do this in my free time on a volunteer basis.

dsalch
Posts: 123
Joined: Wed Jan 06, 2016 2:09 pm
Location: Tx

Re: Slight improvement for 1.9.2 on mobile screens

Post by dsalch »

Looks Perfect!

When will this be released?

d3fz
Posts: 277
Joined: Sun Aug 28, 2016 7:34 pm

Re: Slight improvement for 1.9.2 on mobile screens

Post by d3fz »

Nice suggestion, dsalch.

It is indeed irritating when going back and forth between submenus on mobile devices.

Thank you for looking into it, Lantis.

Looking forward to see this implemented into the next build.
TP-Link Archer C7 v2 - Gargoyle 1.12.X
TP-Link WR842ND v2 - Gargoyle 1.10.X
TP-Link RE450 AC v2 - Stock FW 1.0.4
TP-Link WA850RE v1.2 - LEDE 17.01.1

Lantis
Moderator
Posts: 6735
Joined: Mon Jan 05, 2015 5:33 am
Location: Australia

Re: Slight improvement for 1.9.2 on mobile screens

Post by Lantis »

Hopefully will see it in the unofficial iSpyiSail builds soon!
I have submitted the code to Eric for review today.

https://github.com/ericpaulbishop/gargoyle/pull/630

To land in the official releases in an unknown time factor. Maybe 6 months before the next release.
http://lantisproject.com/downloads/gargoyle_ispyisail.php for the latest releases
Please be respectful when posting. I do this in my free time on a volunteer basis.

Lantis
Moderator
Posts: 6735
Joined: Mon Jan 05, 2015 5:33 am
Location: Australia

Re: Slight improvement for 1.9.2 on mobile screens

Post by Lantis »

This has now been accepted with a slightly different implementation.
Desktop users will notice no difference, however on mobile the menu will now collapse and be navigated without going through multiple pages.

On mobile, if you hide the menu, after a slight delay it will return to its default state for the page you are on i.e. It resets.
http://lantisproject.com/downloads/gargoyle_ispyisail.php for the latest releases
Please be respectful when posting. I do this in my free time on a volunteer basis.

ispyisail
Moderator
Posts: 5180
Joined: Mon Apr 06, 2009 3:15 am
Location: New Zealand

Re: Slight improvement for 1.9.2 on mobile screens

Post by ispyisail »

I just about had it built the Eric pushed another edit.

Build coming

Post Reply