ddns_gargoyle leaves sockets in CLOSE_WAIT status

If your problem doesn't fall into one of the other categories, report it here.

Moderator: Moderators

Post Reply
mackoj
Posts: 3
Joined: Sun Aug 21, 2011 8:33 am

ddns_gargoyle leaves sockets in CLOSE_WAIT status

Post by mackoj »

Hello,
I'm using Gargoyle 1.3.16

I've notice a problem, that ddns_gargoyle is leaving CLOSE_WAIT connections.
As I can see the libewget.c (used by ddns_gargoyle) has a bug in destroy_connection_http function.

Shouldn't be there close(socket) before free(socket)?

Best Regards,
MJ

sco77
Posts: 43
Joined: Tue Nov 09, 2010 7:28 pm

Re: ddns_gargoyle leaves sockets in CLOSE_WAIT status

Post by sco77 »

What all does this bug affect?

mackoj
Posts: 3
Joined: Sun Aug 21, 2011 8:33 am

Re: ddns_gargoyle leaves sockets in CLOSE_WAIT status

Post by mackoj »

ddns-gargoyle leaves open sockets, so you have to restart it to free resources.

sco77
Posts: 43
Joined: Tue Nov 09, 2010 7:28 pm

Re: ddns_gargoyle leaves sockets in CLOSE_WAIT status

Post by sco77 »

So it's only a problem with dynamic DNS? Just wanted to know since I noticed it's been fixed in repository and wanted to know if it was worth compiling.

mackoj
Posts: 3
Joined: Sun Aug 21, 2011 8:33 am

Re: ddns_gargoyle leaves sockets in CLOSE_WAIT status

Post by mackoj »

I noticed the problem with dynDNS only.
However root of the bug is in ewget lib, and I'm not sure if this is even noticeable in ewget.

pbix
Developer
Posts: 1373
Joined: Fri Aug 21, 2009 5:09 pm

Re: ddns_gargoyle leaves sockets in CLOSE_WAIT status

Post by pbix »

It seems Eric has fixed this issue in the repo so it should be correct in the next release of Gargoyle. You can see yourself at http://www.gargoyle-router.com/gargoyle rev:6c66f0cf

Thanks for your investigation and report.
Linksys WRT1900ACv2
Netgear WNDR3700v2
TP Link 1043ND v3
TP-Link TL-WDR3600 v1
Buffalo WZR-HP-G300NH2
WRT54G-TM

Post Reply